deploy: Don't copy xattrs for devicetree #3323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgwalters
force-pushed
the
copydir-no-xattrs
branch
from
293b434 to
14e4ae4
Compare
|
Only compile tested so far |
xref: coreos/fedora-coreos-tracker#1808 For the kernel/initramfs that we copy to `/boot` we use an explicit relabeling today, ignoring the source SELinux context. When we added handling for devicetree it reuse the `copy_dir_recurse` we have for `etc` handling, and that copied the source xattrs. Let's ensure that the devicetree is also `boot_t` by *not* copying xattrs and relying on the default labeling. Signed-off-by: Colin Walters <[email protected]>
cgwalters
force-pushed
the
copydir-no-xattrs
branch
from
14e4ae4 to
72202df
Compare
|
Do testing on aarch64 with this patch, after finalize-staged, the with the patch: without this patch: |
HuijingHei
approved these changes
Oct 21, 2024
HuijingHei
added a commit
to HuijingHei/ostree
that referenced
this pull request
Oct 31, 2024
xref to coreos/fedora-coreos-tracker#1808 PR ostreedev#3323 fixes the new deployment, but keep the incorrect selinux label for the old deplyment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref: coreos/fedora-coreos-tracker#1808
For the kernel/initramfs that we copy to
/bootwe use an explicit relabeling today, ignoring the source SELinux
context.
When we added handling for devicetree it reuse the
copy_dir_recursewe have for
etchandling, and that copied the source xattrs.Let's ensure that the devicetree is also
boot_tby not copyingxattrs and relying on the default labeling.